Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix unrecovery channel exception #179

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: fix unrecovery channel exception #179

merged 1 commit into from
Sep 4, 2024

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Sep 4, 2024 •
edited
Loading

Motivation

I observe we have some connection issue when restart oxia server that causes the client can't work. the client consist print error logs like:

Caused by: java.net.UnknownHostException: xxxxxxxxx: Name does not resolve
	at java.base/java.net.Inet4AddressImpl.lookupAllHostAddr(Native Method)
	at java.base/java.net.Inet4AddressImpl.lookupAllHostAddr(Unknown Source)
	at java.base/java.net.InetAddress$PlatformResolver.lookupByName(Unknown Source)
	at java.base/java.net.InetAddress.getAddressesFromNameService(Unknown Source)
	at java.base/java.net.InetAddress$NameServiceAddresses.get(Unknown Source)
	at java.base/java.net.InetAddress.getAllByName0(Unknown Source)
	at java.base/java.net.InetAddress.getAllByName(Unknown Source)
	at io.grpc.internal.DnsNameResolver$JdkAddressResolver.resolveAddress(DnsNameResolver.java:632)

The RC is that the channel will not retry after met issues. then constantly return error when send messages by FailingClientStream

the issue introduced by #166

@mattisonchao mattisonchao self-assigned this Sep 4, 2024
@merlimat merlimat merged commit 0b057e9 into main Sep 4, 2024
1 check passed
@merlimat merlimat deleted the fix.auto.reconnect branch September 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

@RobertIndie RobertIndie Awaiting requested review from RobertIndie RobertIndie is a code owner

Assignees

@mattisonchao mattisonchao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattisonchao @merlimat